Personal/pragyagandhi/changes for az auth reconnect#32
Open
pragyagandhi wants to merge 5 commits intomasterfrom
Open
Personal/pragyagandhi/changes for az auth reconnect#32pragyagandhi wants to merge 5 commits intomasterfrom
pragyagandhi wants to merge 5 commits intomasterfrom
Conversation
| assert(nfs->rpc->use_azauth == FALSE); | ||
|
|
||
| nfs->rpc->use_azauth = TRUE; | ||
| /* |
Collaborator
There was a problem hiding this comment.
Lets remove this. Lets set nfs->rpc->use_azauth = TRUE; for azauthNone and AzAuthAAD
|
|
||
| const char *server_version = res->AZAUTH3res_u.resok.server_version; | ||
| const char *server_id = res->AZAUTH3res_u.resok.serverid; | ||
| const uint64_t server_cap_map = res->AZAUTH3res_u.resok.server_cap_map; |
Collaborator
There was a problem hiding this comment.
remove the capability changes from this PR.
| assert(rpc->tls_context.state == TLS_HANDSHAKE_COMPLETED); | ||
|
|
||
| if (rpc->use_azauth) { | ||
| uint64_t val = 1; |
|
|
||
| #ifdef ENABLE_INSECURE_AUTH_FOR_DEVTEST | ||
| if (rpc->use_azauth) { | ||
| if (val == 1) { |
Collaborator
There was a problem hiding this comment.
Instead of this add condition in rpc_auth_needs_refresh() to check if rpc->auth_context.auth_type == AzAuthNone return false.
| { | ||
| /* | ||
| * AZAUTH RPC is the only one queued with head priority and | ||
| * AZAUTH RPC MUST only be sent if use_azauth is true. |
| * AZAUTH RPC is the only one queued with head priority and | ||
| * AZAUTH RPC MUST only be sent if use_azauth is true. | ||
| */ | ||
| assert(!pdu->is_head_prio || rpc->use_azauth); |
| * AZAUTH RPC MUST only be sent if use_azauth is true. | ||
| */ | ||
| assert(!pdu->is_head_prio || rpc->use_azauth); | ||
| //assert(!pdu->is_head_prio || rpc->use_azauth); |
| */ | ||
| if (rpc->use_azauth && | ||
| !rpc->auth_context.is_authorized && | ||
| if (!rpc->auth_context.is_authorized && |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.